On 8/22/25 12:57 PM, Alice Ryhl wrote:
On Fri, Aug 22, 2025 at 11:52:21AM +0200, Boris Brezillon wrote:
On Fri, 22 Aug 2025 09:28:24 +0000
Maybe it's time we start moving some bits of the gpuva field docs next
to the fields they describe:
/**
* @gpuva: Fields used by GPUVM to manage mappings pointing to this GEM
object.
*/
struct {
/**
* @gpuva.list: list of GPU VAs attached to this GEM object.
*
* Drivers should lock list accesses with the GEMs &dma_resv
lock
* (&drm_gem_object.resv) or &drm_gem_object.gpuva.lock if the
* list is being updated in places where the resv lock can't be
* acquired (fence signalling path).
*/
struct list_head list;
This isn't a new issue, but it's somewhat confusing to call it a list of
VAs when it's a list of vm_bos.
Yes, I already suggested (don't remember where though) to change the name of the
anonymous accordingly. I think I forgot to rename it back when I introduced
struct drm_gpuvm_bo.
If you want, please add a patch for this in the next version. But it's also fine
to leave as is for your series of course. I can also fix it up. :)
