On Wed, Jul 30, 2025 at 07:02:45PM +0200, Louis Chauvet wrote:
> The dt-bindings for the multi-function device (mfd) syscon need to include
> ti,am625-dss-clk-ctrl. On AM625 chips, the display controller (tidss) has
> external registers to control certain clock properties. These registers
> are located in the device configuration registers, so they need to be
> declared using syscon. They will later be used with a phandle in the tidss
> node.
I don't understand above commit msg. You add new compatible (new device)
but entire commit msg describes something else - some sort of a fix.
>
> Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display
> SubSystem")
Heh? How? How adding a new driver needs fixes in the bindings?
This is just confusing.
> Signed-off-by: Louis Chauvet <[email protected]>
> ---
>
> Cc: [email protected]
That's not the way to add stable tag. See stable-kernel docs or any git
log history.
> ---
> Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index
> 27672adeb1fedb7c81b8ae86c35f4f3b26d5516f..afe4a2a19591e90c850c05ef5888f18bdb64eac9
> 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -121,6 +121,7 @@ select:
> - ti,am62-opp-efuse-table
> - ti,am62-usb-phy-ctrl
> - ti,am625-dss-oldi-io-ctrl
> + - ti,am625-dss-clk-ctrl
Don't break the order. o > c
> - ti,am62p-cpsw-mac-efuse
> - ti,am654-dss-oldi-io-ctrl
> - ti,j784s4-acspcie-proxy-ctrl
> @@ -228,6 +229,7 @@ properties:
> - ti,am62-opp-efuse-table
> - ti,am62-usb-phy-ctrl
> - ti,am625-dss-oldi-io-ctrl
> + - ti,am625-dss-clk-ctrl
Same here
I don't understand also why you are adding clock to syscon. Clock
controllers have their own bindings.
Best regards,
Krzysztof
