On 31/07/2025 15:50, Michal Wilczynski wrote: > Update the img,powervr-rogue.yaml to include the T-HEAD TH1520 SoC's > specific GPU compatible string. > > The thead,th1520-gpu compatible, along with its full chain > img,img-bxm-4-64, and img,img-rogue, is added to the > list of recognized GPU types. > > While the BXM-4-64 GPU IP is designed with two distinct power domains, > the TH1520 SoC integrates it with only a single, unified power gate that > is controllable by the kernel. > > The binding enforces this with a specific if block for the > thead,th1520-gpu compatible that requires a single power-domains entry > and disallows power-domain-names. > > The B-series GPU rule is also updated to include img,img-bxm-4-64 > and to explicitly exclude the TH1520. > > Signed-off-by: Michal Wilczynski <[email protected]> > --- > .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 29 > +++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index > 24ce46ba0b7015fca799f045ee2ccdd258088068..e47e0f3d1b5078b3050e26f6c1ac175edec528ec > 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -21,6 +21,11 @@ properties: > # work with newer dts. > - const: img,img-axe > - const: img,img-rogue > + - items: > + - enum: > + - thead,th1520-gpu > + - const: img,img-bxm-4-64 > + - const: img,img-rogue > - items: > - enum: > - ti,j721s2-gpu > @@ -96,7 +101,29 @@ allOf: > properties: > compatible: > contains: > - const: img,img-bxs-4-64 > + const: thead,th1520-gpu > + then: > + properties: > + power-domains: > + items: > + - description: The single, unified power domain for the GPU on > the > + TH1520 SoC, integrating all internal IP power domains. > + power-domain-names: false > + required: > + - power-domains > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - img,img-bxm-4-64
I don't understand this. There is no such variant like not thead and img,img-bxm-4-64. So same comment as last time: this is overcomplicated. Use simple clauses covering all possible variants. Do not add clauses for impossible combinations. Best regards, Krzysztof
