> On 26 Jun 2025, at 13:23, Beata Michalska <[email protected]> wrote:
> 
> With the Opaque<T>, the expectations are that Rust should not
> make any assumptions on the layout or invariants of the wrapped
> C types. That runs rather counter to ioctl arguments, which must
> adhere to certain data-layout constraints. By using Opaque<T>,
> ioctl handlers are forced to use unsafe code where none is actually
> needed. This adds needless complexity and maintenance overhead,
> brining no safety benefits.
> Drop the use of Opaque for ioctl arguments as that is not the best
> fit here.
> 
> Signed-off-by: Beata Michalska <[email protected]>
> Acked-by: Danilo Krummrich <[email protected]>
> Reviewed-by: Boqun Feng <[email protected]>

Reviewed-by: Daniel Almeida <[email protected]> 

Reply via email to