On 11/06/2025 00:12, Chia-I Wu wrote: > On Mon, Jun 2, 2025 at 7:33 AM Karunika Choo <[email protected]> wrote: >> >> This patch provides an initialization framework for multiple Mali GPUs >> by introducing a GPU support look-up table. Each entry contains, at >> minimum, the architecture major version of the GPU, and may optionally >> provide feature flags and register offset overrides. > <snipped> >> +/** >> + * struct panthor_hw - GPU specific register mapping and functions >> + */ >> +struct panthor_hw { >> + /** @arch_major: Architecture major to match against */ >> + u32 arch_major; >> + >> + /** @features: Bitmap containing panthor_hw_feature */ >> + DECLARE_BITMAP(features, PANTHOR_HW_FEATURES_END); >> + >> + /** @map: Panthor regmap */ >> + struct panthor_hw_regmap map; >> + >> + /** @ops: Panthor HW specific operations */ >> + struct panthor_hw_ops ops; >> +}; > None of the fields are really needed even at the end of this series. > > Can we merge patch 1 & 2, introduce just panthor_hw_init and nothing > else, and let panthor_hw_init call panthor_gpu_init_info?
Hello, I have tried to address this in PATCH 1/6 of v5: - https://lore.kernel.org/all/[email protected]/ > > >> + >> +int panthor_hw_init(struct panthor_device *ptdev); >> + >> +bool panthor_hw_supports(struct panthor_device *ptdev, >> + enum panthor_hw_feature feature); >> + >> +#endif /* __PANTHOR_HW_H__ */ >> + >> -- >> 2.49.0 >>
