On Mon, Jul 7, 2025 at 4:42 AM Konrad Dybcio <[email protected]> wrote: > > On 7/5/25 4:52 PM, Rob Clark wrote: > > Avoid the possibility of missing features between the split and unified > > drm driver cases by defining DRIVER_FEATURES_GPU / KMS and using those > > in the drm_driver initializations. > > > > Signed-off-by: Rob Clark <[email protected]> > > --- > > drivers/gpu/drm/msm/msm_drv.c | 31 ++++++++++++++++--------------- > > 1 file changed, 16 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > index b6efc5b9933b..5695de1bbae2 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.c > > +++ b/drivers/gpu/drm/msm/msm_drv.c > > @@ -816,14 +816,21 @@ static const struct file_operations fops = { > > .show_fdinfo = drm_show_fdinfo, > > }; > > > > +#define DRIVER_FEATURES_GPU ( \ > > + DRIVER_GEM | \ > > + DRIVER_GEM_GPUVA | \ > > + DRIVER_RENDER | \ > > + DRIVER_SYNCOBJ_TIMELINE | \ > > + 0 ) > > + > > +#define DRIVER_FEATURES_KMS ( \ > > + DRIVER_GEM | \ > > + DRIVER_ATOMIC | \ > > + DRIVER_MODESET | \ > > + 0 ) > > Perhaps I'm missing some C lore, but do we need the "| 0"?
It is just to avoid later diffstat noise when new flags are added :-) BR, -R
