On Fri, Jun 20, 2025 at 05:31:03PM +0800, Yongbang Shi wrote: > From: Baihan Li <[email protected]> > > When using command rmmod and insmod, there is no showing in second time > insmoding. Because DP controller won't send HPD signals, if connection > doesn't change or controller isn't reset. So add reset before unreset > in hibmc_dp_hw_init(). > > Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq > feature") > Fixes: 94ee73ee3020 ("drm/hisilicon/hibmc: add dp hw moduel in hibmc driver")
So, which one had the issue? > Signed-off-by: Baihan Li <[email protected]> > Signed-off-by: Yongbang Shi <[email protected]> > --- > ChangeLog: > v1 -> v2: > - fix the tag, suggested by Dmitry Baryshkov. > - separate the patch, suggested by Dmitry Baryshkov. > --- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c > b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c > index 5b1f943b601c..edb7539d830e 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c > @@ -178,6 +178,8 @@ int hibmc_dp_hw_init(struct hibmc_dp *dp) > writel(0, dp_dev->base + HIBMC_DP_INTR_ENABLE); > writel(HIBMC_DP_INT_RST, dp_dev->base + HIBMC_DP_INTR_ORIGINAL_STATUS); > /* rst */ > + writel(0, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL); > + usleep_range(30, 50); > writel(HIBMC_DP_DPTX_RST, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL); > /* clock enable */ > writel(HIBMC_DP_CLK_EN, dp_dev->base + HIBMC_DP_DPTX_CLK_CTRL); > -- > 2.33.0 > -- With best wishes Dmitry
