Hi Prabhakar, Thank you for the patch.
On Fri, May 30, 2025 at 05:59:06PM +0100, Prabhakar wrote: > From: Lad Prabhakar <[email protected]> > > Add LPCLK clock support in the RZ/G2L MIPI DSI driver via the optional > clock API. This clock is required by some SoCs like RZ/V2H(P) for proper > DPHY configuration, whereas it is absent on others like RZ/G2L. > > Introduce a new `lpclk` field in the `rzg2l_mipi_dsi` structure and > conditionally acquire the "lpclk" clock using `devm_clk_get_optional()` > during probe. This allows LPCLK-aware SoCs to pass the clock via device > tree without impacting existing platforms. > > Co-developed-by: Fabrizio Castro <[email protected]> > Signed-off-by: Fabrizio Castro <[email protected]> > Signed-off-by: Lad Prabhakar <[email protected]> > Reviewed-by: Biju Das <[email protected]> > --- > v5->v6: > - No changes > > v4->v5: > - Made use of devm_clk_get_optional() for lpclk > - Added Reviewed tag from Biju > > v3->v4 > - No changes > > v2->v3: > - No changes > > v1->v2: > - Added LPCLK as feature flag > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > index f9f2d883c40d..a31f9b6aa920 100644 > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > @@ -62,6 +62,7 @@ struct rzg2l_mipi_dsi { > struct drm_bridge *next_bridge; > > struct clk *vclk; > + struct clk *lpclk; > > enum mipi_dsi_pixel_format format; > unsigned int num_data_lanes; > @@ -791,6 +792,10 @@ static int rzg2l_mipi_dsi_probe(struct platform_device > *pdev) > if (IS_ERR(dsi->vclk)) > return PTR_ERR(dsi->vclk); > > + dsi->lpclk = devm_clk_get_optional(dsi->dev, "lpclk"); > + if (IS_ERR(dsi->lpclk)) > + return PTR_ERR(dsi->lpclk); > + This clock isn't used in this series, it will only be used when you will submit the next version of "[PATCH v4 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC". As this patch doesn't bring any used feature, I'm tempted to say it could be bundled with the RZ/V2H(P) support patch. > dsi->rstc = devm_reset_control_get_optional_exclusive(dsi->dev, "rst"); > if (IS_ERR(dsi->rstc)) > return dev_err_probe(dsi->dev, PTR_ERR(dsi->rstc), -- Regards, Laurent Pinchart
