Hi Chris, On Wed, 21 May 2025 17:03:35 -0400 Chris Brandt <[email protected]> wrote:
> When drm_panel.prepare_prev_first is set to true in a panel driver, the > panel expects the MIPI DSI hardware to be already configured before the > panel's prepare function is called because it might need to send DCS > commands. > > Signed-off-by: Chris Brandt <[email protected]> Tested-by: Hugo Villeneuve <[email protected]> Tested by setting "drm_panel.prepare_prev_first = true" with two different LCD panels. Hugo > --- > v1->v2 > - Fixed alignment reported by checkpatch > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > index 4550c6d84796..1202e0ce0188 100644 > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > @@ -531,8 +531,8 @@ static int rzg2l_mipi_dsi_attach(struct drm_bridge > *bridge, > flags); > } > > -static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, > - struct drm_atomic_state *state) > +static void rzg2l_mipi_dsi_atomic_pre_enable(struct drm_bridge *bridge, > + struct drm_atomic_state *state) > { > struct rzg2l_mipi_dsi *dsi = bridge_to_rzg2l_mipi_dsi(bridge); > const struct drm_display_mode *mode; > @@ -549,6 +549,13 @@ static void rzg2l_mipi_dsi_atomic_enable(struct > drm_bridge *bridge, > return; > > rzg2l_mipi_dsi_set_display_timing(dsi, mode); > +} > + > +static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, > + struct drm_atomic_state *state) > +{ > + struct rzg2l_mipi_dsi *dsi = bridge_to_rzg2l_mipi_dsi(bridge); > + int ret; > > ret = rzg2l_mipi_dsi_start_hs_clock(dsi); > if (ret < 0) > @@ -592,6 +599,7 @@ static const struct drm_bridge_funcs > rzg2l_mipi_dsi_bridge_ops = { > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > .atomic_reset = drm_atomic_helper_bridge_reset, > + .atomic_pre_enable = rzg2l_mipi_dsi_atomic_pre_enable, > .atomic_enable = rzg2l_mipi_dsi_atomic_enable, > .atomic_disable = rzg2l_mipi_dsi_atomic_disable, > .mode_valid = rzg2l_mipi_dsi_bridge_mode_valid, > -- > 2.34.1 > >
