Hi Biju, > Check patch is complaining about Alignment. Please check and fix it. > > scripts/checkpatch.pl --strict *.patch
I ran checkpatch first like I always do, but I didn't use --strict. I didn't even know there was such a thing. I'll send a V2 Thanks! Chris -----Original Message----- From: Biju Das <[email protected]> Sent: Wednesday, May 21, 2025 3:41 PM To: Chris Brandt <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Thomas Zimmermann <[email protected]>; David Airlie <[email protected]>; Simona Vetter <[email protected]>; Hien Huynh <[email protected]>; Hugo Villeneuve <[email protected]> Cc: [email protected]; [email protected]; Chris Brandt <[email protected]> Subject: RE: [PATCH] drm: renesas: rz-du: Add atomic_pre_enable Hi Chris Brandt, Thanks for the patch. > -----Original Message----- > From: Chris Brandt <[email protected]> > Sent: 21 May 2025 15:24 > Subject: [PATCH] drm: renesas: rz-du: Add atomic_pre_enable > > When drm_panel.prepare_prev_first is set to true in a panel driver, > the panel expects the MIPI DSI hardware to be already configured > before the panel's prepare function is called because it might need to send > DCS commands. > > Signed-off-by: Chris Brandt <[email protected]> > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > b/drivers/gpu/drm/renesas/rz- du/rzg2l_mipi_dsi.c index > 4550c6d84796..b31affddfc81 100644 > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > @@ -531,7 +531,7 @@ static int rzg2l_mipi_dsi_attach(struct drm_bridge > *bridge, > flags); > } > > -static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, > +static void rzg2l_mipi_dsi_atomic_pre_enable(struct drm_bridge > +*bridge, > struct drm_atomic_state *state) Check patch is complaining about Alignment. Please check and fix it. scripts/checkpatch.pl --strict *.patch CHECK: Alignment should match open parenthesis #26: FILE: drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c:536: +static void rzg2l_mipi_dsi_atomic_pre_enable(struct drm_bridge *bridge, struct drm_atomic_state *state) Cheers, Biju > { > struct rzg2l_mipi_dsi *dsi = bridge_to_rzg2l_mipi_dsi(bridge); @@ > -549,6 +549,13 @@ static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge > *bridge, > return; > > rzg2l_mipi_dsi_set_display_timing(dsi, mode); > +} > + > +static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, > + struct drm_atomic_state *state) { > + struct rzg2l_mipi_dsi *dsi = bridge_to_rzg2l_mipi_dsi(bridge); > + int ret; > > ret = rzg2l_mipi_dsi_start_hs_clock(dsi); > if (ret < 0) > @@ -592,6 +599,7 @@ static const struct drm_bridge_funcs > rzg2l_mipi_dsi_bridge_ops = { > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > .atomic_reset = drm_atomic_helper_bridge_reset, > + .atomic_pre_enable = rzg2l_mipi_dsi_atomic_pre_enable, > .atomic_enable = rzg2l_mipi_dsi_atomic_enable, > .atomic_disable = rzg2l_mipi_dsi_atomic_disable, > .mode_valid = rzg2l_mipi_dsi_bridge_mode_valid, > -- > 2.34.1
