Le 19/05/2025 à 17:34, Danilo Krummrich a écrit :
On Thu, Apr 24, 2025 at 10:38:15AM +0200, Pierre-Eric Pelloux-Prayer wrote:diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h index f56e77e7f6d0..713df3516a17 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -42,6 +42,7 @@ DECLARE_EVENT_CLASS(drm_sched_job, __field(uint64_t, id) __field(u32, job_count) __field(int, hw_job_count) + __string(dev, dev_name(sched_job->sched->dev))Using the sched_job->sched pointer here and in other trace events implies that the trace event must not be called before the sched_job->sched has been set, i.e. in drm_sched_job_arm(). Please document this for the corresponding trace events.
This is not a new requirement as sched and s_fence were already used by the trace events. Still it's a good idea to document this, so I'll update the comment added in the documentation patch. Thanks, Pierre-Eric
