On Mon, May 19, 2025 at 04:30:55PM +0530, Ayushi Makhija wrote:
> On 5/19/2025 6:31 AM, Dmitry Baryshkov wrote:
> > On Tue, May 13, 2025 at 03:56:10PM +0530, Ayushi Makhija wrote:
> >> From: Ayushi Makhija <[email protected]>
> >>
> >> Add device tree nodes for the DSI0 and DSI1 controllers
> >> with their corresponding PHYs found on Qualcomm SA8775P SoC.
> >>
> >> Signed-off-by: Ayushi Makhija <[email protected]>
> >> Reviewed-by: Dmitry Baryshkov <[email protected]>
> >> Reviewed-by: Konrad Dybcio <[email protected]>
> >> ---
> >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 186 +++++++++++++++++++++++++-
> >> 1 file changed, 185 insertions(+), 1 deletion(-)
> >> +
> >> + dsi0_opp_table: opp-table {
> >
> > mdss_dsi_opp_table: opp-table {}
> >
> >> + compatible = "operating-points-v2";
> >> +
> >> + opp-358000000 {
> >
> > Is there only one entry? Usually there are several.
> >
>
> Hi Dmitry,
>
> Thanks, for the review.
>
> In the IP catalog Clock documentation of SA8775P, the same DSI clock
> frequency (358Mhz)
> is mentioned for all the voltage corners (svs_l1, nom, turbo and turbo_l1).
> That's why I kept the single entry opp-358000000 for 358Mhz and selected
> lowest voltage corner svs_l1.
>
> I will address rest of the comments in next version of series.
Ack, thanks for the confirmation.
--
With best wishes
Dmitry
