Hi,
On Tue, Feb 4, 2025 at 6:59 AM Maxime Ripard <[email protected]> wrote:
>
> drm_atomic_bridge_chain_pre_enable() enables all bridges affected by
> a new commit. It takes the drm_atomic_state being committed as a
> parameter.
>
> However, that parameter name is called (and documented) as old_state,
> which is pretty confusing. Let's rename that variable as state.
>
> Signed-off-by: Maxime Ripard <[email protected]>
> ---
> drivers/gpu/drm/drm_bridge.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index
> ab166972b1b0df239ca014296be49846a857df6e..02ddfe962b99bed4316b2a7b0c72112e127afa8b
> 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -672,23 +672,23 @@ void drm_atomic_bridge_chain_post_disable(struct
> drm_bridge *bridge,
> }
> }
> EXPORT_SYMBOL(drm_atomic_bridge_chain_post_disable);
>
> static void drm_atomic_bridge_call_pre_enable(struct drm_bridge *bridge,
> - struct drm_atomic_state
> *old_state)
> + struct drm_atomic_state *state)
> {
> if (old_state && bridge->funcs->atomic_pre_enable)
drivers/gpu/drm/drm_bridge.c:683:6: error: use of undeclared
identifier 'old_state'; did you mean 'node_state'?
683 | if (old_state && bridge->funcs->atomic_pre_enable)
| ^~~~~~~~~
| node_state
