Hi Cristian, Am Mittwoch, 11. Dezember 2024, 00:06:13 CET schrieb Cristian Ciocaltea: > The patches provide the basic support to handle the second HDMI output > port found on Rockchip RK3588 SoC. > > For now I enabled it on Radxa ROCK 5B only, the board I've been using to > validate this. > > ** IMPORTANT ** > > The series has a runtime dependency on "phy: phy-rockchip-samsung-hdptx: > Don't use dt aliases to determine phy-id", a patch submitted recently by > Heiko [1]. Without applying it, the functionality on both HDMI TX ports > will break.
Looking at the drm/rockchip patch, that should not cause disruptions on its own, right? Only with the dts-parts enabled would we run into phy-issue. (Asking, because things go through different trees and the drm part looks ready) Heiko > Furthermore, please note this is subject to the same limitations as > HDMI0 when it comes to the supported display modes. The fixes provided > via [2] are not applicable to HDMI1, hence I will handle it separately > as soon as all dependencies are merged. > > Thanks, > Cristian > > [1] https://lore.kernel.org/lkml/[email protected]/ > [2] > https://lore.kernel.org/all/[email protected]/ > > Signed-off-by: Cristian Ciocaltea <[email protected]> > --- > Changes in v2: > - Override hdmi1 pinctrl-0 on rock-5b as it requires hdmim0_tx1_cec > instead of hdmim2_tx1_cec (fixes a pin conflict when enabling > CONFIG_SPI_ROCKCHIP_SFC) > - Link to v1: > https://lore.kernel.org/r/[email protected] > > --- > Cristian Ciocaltea (4): > drm/rockchip: dw_hdmi_qp: Add support for RK3588 HDMI1 output > arm64: dts: rockchip: Add PHY node for HDMI1 TX port on RK3588 > arm64: dts: rockchip: Add HDMI1 node on RK3588 > arm64: dts: rockchip: Enable HDMI1 on rock-5b > > arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 62 ++++++++++++ > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 44 ++++++++- > drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 119 > +++++++++++++++++++----- > 3 files changed, 200 insertions(+), 25 deletions(-) > --- > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 > change-id: 20241207-rk3588-hdmi1-704cbb7cd75f > >
