On 21/11/2024 03:15, Keith Zhao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <[email protected]> >> Sent: 2024年11月20日 15:38 >> To: Keith Zhao <[email protected]>; [email protected]; >> [email protected] >> Cc: [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; William Qiu >> <[email protected]>; Xingyu Wu <[email protected]>; >> [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; Changhuang Liang >> <[email protected]>; Jack Zhu <[email protected]>; >> [email protected] >> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver. >> >> On 20/11/2024 07:18, keith zhao wrote: >>> + /* Unmute hotplug interrupt */ >>> + hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG, >>> +v_MASK_INT_HOTPLUG(1)); >>> + >>> + ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq, >>> + inno_hdmi_irq, IRQF_SHARED, >>> + dev_name(hdmi->dev), hdmi); >>> + return ret; >>> +} >>> +EXPORT_SYMBOL_GPL(inno_hdmi_bind); >>> + >>> +MODULE_AUTHOR("Keith Zhao <[email protected]>"); >>> +MODULE_DESCRIPTION("INNO HDMI transmitter driver"); >>> +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:inno-hdmi"); >> >> You should not need MODULE_ALIAS() in normal cases. If you need it, usually >> it >> means your device ID table is wrong (e.g. misses either entries or >> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete >> ID table. >> > Thank you for your suggestion! > I will review the device ID table to ensure its completeness > and avoid using MODULE_ALIAS().
In this context neither MODULE_ALIAS nor ID table are suitable/needed. If you need them, means your driver does not build in all setups :/ Best regards, Krzysztof
