On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote:
> During suspend/resume process all connectors are explicitly disabled and
> then reenabled. However resume fails because of the connector_status check:
>
> [ 1185.831970] [dpu error]connector not connected 3
Please also include the follow-on resume error. I'm seeing:
[dpu error]connector not connected 3
[drm:drm_mode_config_helper_resume [drm_kms_helper]] *ERROR* Failed to
resume (-22)
and say something about that this can prevent displays from being
enabled on resume in some setups (preferably with an explanation why if
you have one).
> It doesn't make sense to check for the Writeback connected status (and
> other drivers don't perform such check), so drop the check.
>
> Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to
> dpu_writeback.c")
I noticed that the implementation had this status check also before
71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to
dpu_writeback.c").
Why did this not cause any trouble back then? Or is this not the right
Fixes tag?
> Cc: [email protected]
> Reported-by: Leonard Lausen <[email protected]>
> Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57
Perhaps you can include mine an György's reports here too.
> Signed-off-by: Dmitry Baryshkov <[email protected]>
With the above addressed:
Reviewed-by: Johan Hovold <[email protected]>
Tested-by: Johan Hovold <[email protected]>
Johan
