Hi, On Wed, Aug 28, 2024 at 11:03:20AM GMT, Yafang Shao wrote: > To prevent errors from occurring when the src string is longer than the dst > string in strcpy(), we should use strscpy() instead. This approach > also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Eric Dumazet <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Paolo Abeni <[email protected]> > --- > net/ipv6/ndisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c > index b8eec1b6cc2c..cf7c36463b33 100644 > --- a/net/ipv6/ndisc.c > +++ b/net/ipv6/ndisc.c > @@ -1944,7 +1944,7 @@ static void ndisc_warn_deprecated_sysctl(const struct > ctl_table *ctl, > static char warncomm[TASK_COMM_LEN]; > static int warned; > if (strcmp(warncomm, current->comm) && warned < 5) { > - strcpy(warncomm, current->comm); > + strscpy(warncomm, current->comm); > pr_warn("process `%s' is using deprecated sysctl (%s) > net.ipv6.neigh.%s.%s - use net.ipv6.neigh.%s.%s_ms instead\n", > warncomm, func, > dev_name, ctl->procname, > -- > 2.43.5 > >
Reviewed-by: Justin Stitt <[email protected]> Thanks Justin
