Hi Lucas, On Tue, Aug 20, 2024 at 07:53:10AM -0500, Lucas De Marchi wrote: > On Tue, Aug 20, 2024 at 05:53:02PM GMT, Yu Jiaoliang wrote: > > Let the kememdup_array() take care about multiplication and possible > > overflows. > > > > v2: > > - Change subject > > - Leave one blank line between the commit log and the tag section > > - Fix code alignment issue > > > > Signed-off-by: Yu Jiaoliang <[email protected]> > > Reviewed-by: Jani Nikula <[email protected]> > > Reviewed-by: Andi Shyti <[email protected]> > > --- > > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > > index d90348c56765..0fcfd55c62b4 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > > @@ -111,9 +111,8 @@ static void wa_init_finish(struct i915_wa_list *wal) > > { > > /* Trim unused entries. */ > > if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) { > > - struct i915_wa *list = kmemdup_array(wal->list, > > ^ > > it was already kmemdup_array, not kmemdup. Am I missing anything?
I see kmemdup() in drm-tip. What Yu has done here is to change kmemdup to kmemdup_array and send the patch. Received the reviews and made a new commit on top of the previous one; then he sent only this second commit. Yu needs to make sure that: 1. the patch applies correctly on a clean drm-tip 2. drm-tip + patch compiles 3. there are no checkpatch and sparse new errors We missed point 1 here :-) Andi
