Hi, thanks for your feedback.
Am Dienstag, 28. Mai 2024, 12:02:29 CEST schrieb Liu Ying: > On 05/28/2024, Alexander Stein wrote: > > Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible > > removed), it lines up with the other error paths in probe function. > > > > Signed-off-by: Alexander Stein <[email protected]> > > --- > > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > index 2347f8dd632f9..8331db3b4f054 100644 > > --- a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > +++ b/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c > > @@ -841,11 +841,9 @@ static int imx93_dsi_probe(struct platform_device > > *pdev) > > return -ENOMEM; > > > > dsi->regmap = syscon_regmap_lookup_by_phandle(np, "fsl,media-blk-ctrl"); > > - if (IS_ERR(dsi->regmap)) { > > - ret = PTR_ERR(dsi->regmap); > > - dev_err(dev, "failed to get block ctrl regmap: %d\n", ret); > > - return ret; > > - } > > + if (IS_ERR(dsi->regmap)) > > + return dev_err_probe(dev, PTR_ERR(dsi->regmap), > > + "failed to get block ctrl regmap"); > > Missing \n. > > And, a build warning: > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c: In function ‘imx93_dsi_probe’: > drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c:837:13: warning: unused variable > ‘ret’ [-Wunused-variable] > 837 | int ret; > | ^~~ > Nice catch. Thanks. I'll send v2 tomorrow. Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
