-----Original Message----- From: Krzysztof Kozlowski <[email protected]> Sent: den 19 april 2024 01:05 To: Johan Adolfsson <[email protected]>; Neil Armstrong <[email protected]>; Jessica Zhang <[email protected]>; Sam Ravnborg <[email protected]>; Maarten Lankhorst <[email protected]>; Maxime Ripard <[email protected]>; Thomas Zimmermann <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Thierry Reding <[email protected]> Cc: [email protected]; [email protected]; [email protected]; kernel <[email protected]> Subject: Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi
>On 18/04/2024 16:01, Johan Adolfsson wrote: >> panel-dsi is similar to panel-dpi with overridable timings > >??? I guess a more correct description would be "panel-dsi is a fallback in a similar way that panel-dpi is in panel-dpi.yaml .."? ... >> a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yam >> l >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi >> +++ .yaml >> @@ -56,6 +56,8 @@ properties: >> - samsung,sofef00 >> # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT >> LCD panel >> - tdo,tl070wsh30 >> + # Generic dsi panel with timing overridable >> + - panel-dsi > >? Devices are not generic. This is very confusing and commit msg does not help >me. Compatibles *must* be specific, see writing-bindings. I guess I see this a generic fallback, that handles any dsi panel as long as the correct timing etc is specified in devictree, similar to what panel-dpi is in panel-dpi.yaml Maybe phrasing it similar to panel-dpi.yaml is better? >Best regards, >Krzysztof Best regards /Johan
