On Sat, Mar 02, 2024 at 12:55:48PM +0300, Dmitry Baryshkov wrote: > On Fri, 1 Mar 2024 at 18:22, Imre Deak <[email protected]> wrote: > > > > If drm_kms_helper_poll=n the output poll work will only get scheduled > > from drm_helper_probe_single_connector_modes() to handle a delayed > > hotplug event. Since polling is disabled the work in this case should > > just call drm_kms_helper_hotplug_event() w/o detecting the state of > > connectors and rescheduling the work. > > > > After commit d33a54e3991d after a delayed hotplug event above the > > connectors did get re-detected in the poll work and the work got > > re-scheduled periodically (since poll_running is also false if > > drm_kms_helper_poll=n), in effect ignoring the drm_kms_helper_poll=n > > kernel param. > > > > Fix the above by calling only drm_kms_helper_hotplug_event() for a > > delayed hotplug event if drm_kms_helper_hotplug_event=n, as was done > > before d33a54e3991d. > > > > Cc: Dmitry Baryshkov <[email protected]> > > Reported-by: Ville Syrjälä <[email protected]> > > Fixes: d33a54e3991d ("drm/probe_helper: sort out poll_running vs > > poll_enabled") > > Reviewed-by: Dmitry Baryshkov <[email protected]>
Patch is pushed to drm-misc-fixes, thanks for the report and review. > > > Signed-off-by: Imre Deak <[email protected]> > > --- > > drivers/gpu/drm/drm_probe_helper.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > -- > With best wishes > Dmitry
