On Mon, 04 Mar 2024, Thomas Zimmermann <[email protected]> wrote: > Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for > the backlight header has recently been removed from <linux/fb.h>. > > Reported-by: Naresh Kamboju <[email protected]> > Closes: > https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/ > Signed-off-by: Thomas Zimmermann <[email protected]> > Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") > Cc: Thomas Zimmermann <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Helge Deller <[email protected]> > Cc: [email protected] > Cc: [email protected]
I would've added the include in arch/powerpc/include/asm/backlight.h [1], but either way is fine by me. Reviewed-by: Jani Nikula <[email protected]> [1] https://lore.kernel.org/r/[email protected] > --- > drivers/video/fbdev/chipsfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c > index b80711f13df8a..b16a905588fed 100644 > --- a/drivers/video/fbdev/chipsfb.c > +++ b/drivers/video/fbdev/chipsfb.c > @@ -15,6 +15,7 @@ > */ > > #include <linux/aperture.h> > +#include <linux/backlight.h> > #include <linux/module.h> > #include <linux/kernel.h> > #include <linux/errno.h> -- Jani Nikula, Intel
