On 04/03/2024 09:23, Krzysztof Kozlowski wrote:
>
>> + return PTR_ERR(data->regmap);
>> + }
>> + i2c_set_clientdata(client, data);
>> +
>> + data->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
>> + if (IS_ERR(data->reset_gpio)) {
>> + ret = PTR_ERR(data->reset_gpio);
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(dev, "fail : get reset GPIO: %d\n", ret);
>
> No, don't upstream old vendor code directly but instead choose existing
> mainline driver and customize it. The syntax is `return dev_err_probe()
Hm, I found such pattern in gpio backlight. I'll fix it.
Best regards,
Krzysztof
