On Wed, Dec 6, 2023 at 2:52 PM Lingkai Dong <[email protected]> wrote:
> The DRM subsystem keeps a record of the owner of a DRM device file
> descriptor using thread group ID (TGID) instead of process ID (PID), to
> ensures all threads within the same userspace process are considered the
> owner. However, the DRM master ownership check compares the current
> thread's PID against the record, so the thread is incorrectly considered to
> be not the FD owner if the PID is not equal to the TGID. This causes DRM
> ioctls to be denied master privileges, even if the same thread that opened
> the FD performs an ioctl. Fix this by checking TGID.
>
> Fixes: 4230cea89cafb ("drm: Track clients by tgid and not tid")
> Signed-off-by: Lingkai Dong <[email protected]>
Paging the patch author (Tvrko) and committer (Christian).
Here is the patch if you don't have it in your mailbox:
https://lore.kernel.org/dri-devel/pa6pr08mb107665920be9a96658cda04ce88...@pa6pr08mb10766.eurprd08.prod.outlook.com/
I'm seeing this as well (on Android).
Tvrko, Christian: can you look at this?
Will you apply it to the AMD tree for fixes if it looks OK
or does it go elsewhere?
Yours,
Linus Walleij
