On Tue, Dec 05, 2023 at 12:05:02PM +0300, Dan Carpenter wrote:
> On Tue, Dec 05, 2023 at 09:37:05AM +0100, Maxime Ripard wrote:
> > Hi Naresh,
> >
> > Thanks for the report
> >
> > On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
> > > The Kunit drm_plane_helper failed on all devices running Linux
> > > next-20231204
> > >
> > > ## Test Regressions (compared to next-20231201)
> > > * qemu-armv7, kunit and
> > > * x86, kunit
> > > - drm_test_check_invalid_plane_state_downscaling_invalid
> > > - drm_test_check_invalid_plane_state_drm_plane_helper
> > > - drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
> > > - drm_test_check_invalid_plane_state_positioning_invalid
> > > - drm_test_check_invalid_plane_state_upscaling_invalid
> > > - drm_test_check_plane_state_clipping_rotate_reflect
> > > - drm_test_check_plane_state_clipping_simple
> > > - drm_test_check_plane_state_downscaling
> > > - drm_test_check_plane_state_drm_test_check_plane_state
> > > - drm_test_check_plane_state_positioning_simple
> > > - drm_test_check_plane_state_rounding1
> > > - drm_test_check_plane_state_rounding2
> > > - drm_test_check_plane_state_rounding3
> > > - drm_test_check_plane_state_rounding4
> > > - drm_test_check_plane_state_upscaling
> >
> > I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
> > atomic checks").
> >
> > Fortunately for us, it's already been reverted yesterday for some
> > unrelated reason, so it should be fixed in next-20231205 onward.
>
> Sorry, that's a bummer that these patches were reverted. :( The whole
> episode was a bit unfortunate...
>
> Qualcom has been working on those patches for a year. They must not be
> using kunit testing as part of their QC... It's some kind of
> communication failure on our part.That's definitely a communication failure, but that's mostly on us :) The reason these patches were reverted was completely unrelated to the kunit failures here: it failed the basic requirement we have on intel-gpu-tools tests and open-source userspace examples for new uAPIs. So whether or not kunit tests would have passed, these patches were applied due to inattention and would have been reverted anyway Maxime
signature.asc
Description: PGP signature
