> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <[email protected]>; Daniel Vetter <[email protected]>;
> Maarten Lankhorst <[email protected]>; Maxime Ripard
> <[email protected]>; Thomas Zimmermann <[email protected]>;
> Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley
> <[email protected]>; Alim Akhtar <[email protected]>; Andi
> Shyti <[email protected]>; Jonathan Cameron <[email protected]>; Lars-
> Peter Clausen <[email protected]>; Lee Jones <[email protected]>; Ulf
> Hansson <[email protected]>; Tomasz Figa <[email protected]>;
> Sylwester Nawrocki <[email protected]>; Linus Walleij
> <[email protected]>; Thierry Reding <[email protected]>; Uwe
> Kleine-König <[email protected]>; Alessandro Zummo
> <[email protected]>; Alexandre Belloni
> <[email protected]>; Greg Kroah-Hartman
> <[email protected]>; Jiri Slaby <[email protected]>; Liam
> Girdwood <[email protected]>; Mark Brown <[email protected]>;
> Jaehoon Chung <[email protected]>; Sam Protsenko
> <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; alsa-devel@alsa-
> project.org; [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>
> Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add
> specific compatibles for existing SoC
> 
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> 
Reviewed-by: Alim Akhtar <[email protected]>

> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
>  .../bindings/hwinfo/samsung,exynos-chipid.yaml  | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index 95cbdcb56efe..45f3d468db7c 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-
> chipid.yam
> +++ l
> @@ -11,9 +11,20 @@ maintainers:
> 
>  properties:
>    compatible:
> -    enum:
> -      - samsung,exynos4210-chipid
> -      - samsung,exynos850-chipid
> +    oneOf:
> +      - enum:
> +          - samsung,exynos4210-chipid
> +          - samsung,exynos850-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos5433-chipid
> +              - samsung,exynos7-chipid
> +          - const: samsung,exynos4210-chipid
> +      - items:
> +          - enum:
> +              - samsung,exynos7885-chipid
> +              - samsung,exynosautov9-chipid
> +          - const: samsung,exynos850-chipid
> 
>    reg:
>      maxItems: 1
> --
> 2.34.1



Reply via email to