On Fri 13 Jan 2017, Gustavo Padovan wrote: > From: Gustavo Padovan <[email protected]> > > Currently if the userspace declares a int variable to store the out_fence > fd and pass it to OUT_FENCE_PTR the kernel will overwrite the 32 bits > above the int variable on 64 bits systems. > > Fix this by making the internal storage of out_fence in the kernel a s32 > pointer. > > Reported-by: Chad Versace <[email protected]> > Signed-off-by: Gustavo Padovan <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Rafael Antognolli <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: [email protected]
Reviewed-and-Tested-by: Chad Versace <[email protected]> I applied this to my kernel branch, updated kmscube, and the spinning cube still looks good. For reference, here are the tags I tested with: mesa: http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/i965-exec-fence-v03 libdrm: http://git.kiwitree.net/cgit/~chadv/libdrm/tag/?h=chadv/review/intel-exec-fence-v01 linux: http://git.kiwitree.net/cgit/~chadv/linux/tag/?h=chadv/test/i915-exec-fence-v04 kmscube: http://git.kiwitree.net/cgit/~chadv/kmscube/tag/?h=chadv/test/fences-v03 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
