Nice catch! Reviewed-by: Lyude Paul <[email protected]>
Will push in just a moment On Thu, 2023-09-14 at 21:59 -0700, Kees Cook wrote: > On Thu, Sep 14, 2023 at 10:17:08PM +0000, Justin Stitt wrote: > > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > > > We should prefer more robust and less ambiguous string interfaces. > > > > A suitable replacement is `strscpy` [2] due to the fact that it guarantees > > NUL-termination on the destination buffer without unnecessarily NUL-padding. > > > > Link: > > https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > > [1] > > Link: > > https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > > Link: https://github.com/KSPP/linux/issues/90 > > Cc: [email protected] > > Signed-off-by: Justin Stitt <[email protected]> > > The "- 1" use in the original code is strong evidence for this being a > sane conversion. :) > > Reviewed-by: Kees Cook <[email protected]> > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
