On Thu, 14 Sep 2023 15:10, Jani Nikula <[email protected]> wrote: >Setting new_edid to NULL leaks the buffer. > >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") >Cc: Markus Schneider-Pargmann <[email protected]> >Cc: Guillaume Ranquet <[email protected]> >Cc: Bo-Chen Chen <[email protected]> >Cc: CK Hu <[email protected]> >Cc: AngeloGioacchino Del Regno <[email protected]> >Cc: Dmitry Osipenko <[email protected]> >Cc: Chun-Kuang Hu <[email protected]> >Cc: Philipp Zabel <[email protected]> >Cc: Matthias Brugger <[email protected]> >Cc: [email protected] >Cc: [email protected] >Cc: [email protected] >Cc: [email protected] >Cc: <[email protected]> # v6.1+ >Signed-off-by: Jani Nikula <[email protected]> >
Reviewed-by: Guillaume Ranquet <[email protected]> >--- > >UNTESTED >--- > drivers/gpu/drm/mediatek/mtk_dp.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c >b/drivers/gpu/drm/mediatek/mtk_dp.c >index 2cb47f663756..8fc6eff68e30 100644 >--- a/drivers/gpu/drm/mediatek/mtk_dp.c >+++ b/drivers/gpu/drm/mediatek/mtk_dp.c >@@ -2049,6 +2049,7 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge >*bridge, > */ > if (mtk_dp_parse_capabilities(mtk_dp)) { > drm_err(mtk_dp->drm_dev, "Can't parse capabilities\n"); >+ kfree(new_edid); > new_edid = NULL; > } > >-- >2.39.2 >
