On 9/1/2023 3:49 AM, Stanislaw Gruszka wrote:
ivpu_pm_init() does not return any error, make it void.

Reviewed-by: Karol Wachowski <[email protected]>
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
  drivers/accel/ivpu/ivpu_drv.c | 4 +---
  drivers/accel/ivpu/ivpu_fw.c  | 2 +-
  drivers/accel/ivpu/ivpu_pm.c  | 4 +---
  drivers/accel/ivpu/ivpu_pm.h  | 2 +-
  4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index 4b344ab614f6..b10b2909f05f 100644
--- a/drivers/accel/ivpu/ivpu_drv.c
+++ b/drivers/accel/ivpu/ivpu_drv.c
@@ -551,9 +551,7 @@ static int ivpu_dev_init(struct ivpu_device *vdev)
        if (ret)
                goto err_fw_fini;
- ret = ivpu_pm_init(vdev);
-       if (ret)
-               goto err_ipc_fini;
+       ivpu_pm_init(vdev);
ret = ivpu_job_done_thread_init(vdev);
        if (ret)
diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
index 9827ea4d7b83..9b6ecd3e9537 100644
--- a/drivers/accel/ivpu/ivpu_fw.c
+++ b/drivers/accel/ivpu/ivpu_fw.c
@@ -78,7 +78,7 @@ static int ivpu_fw_request(struct ivpu_device *vdev)
                }
        }
- ivpu_err(vdev, "Failed to request firmware: %d\n", ret);
+       ivpu_err(vdev, "Failed to load firmware: %d\n", ret);

I feel that this is unrelated to $SUBJECT. With this dropped or moved to where it fits -

Reviewed-by: Jeffrey Hugo <[email protected]>

Reply via email to