On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas <[email protected]> wrote: > > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] > Selected by [y]: > - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] > > Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the > DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could > be to enable DRM fbdev emulation but without a framebuffer console. > > Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation > is enabled") > Reported-by: Arthur Grillo <[email protected]> > Closes: > https://lore.kernel.org/dri-devel/[email protected] > Suggested-by: Arnd Bergmann <[email protected]> > Signed-off-by: Javier Martinez Canillas <[email protected]>
Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-) Acked-by: Daniel Vetter <[email protected]> Cheers, Sima > --- > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index b51c6a141dfa..2a44b9419d4d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help > -- > 2.41.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
