On Thu, Aug 3, 2023 at 1:45 PM Daniel Vetter <[email protected]> wrote: > > Apparently no one noticed that mdp5 plane states leak like a sieve > ever since we introduced plane_state->commit refcount a few years ago > in 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too > early by tracking commits, v3.") > > Fix it by using the right helpers. > > Fixes: 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too early > by tracking commits, v3.") > Cc: Maarten Lankhorst <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Rob Clark <[email protected]> > Cc: Abhinav Kumar <[email protected]> > Cc: Dmitry Baryshkov <[email protected]> > Cc: [email protected] > Cc: [email protected] > Reported-and-tested-by: [email protected] > Cc: [email protected] > Signed-off-by: Daniel Vetter <[email protected]>
Reviewed-by: Rob Clark <[email protected]> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > index bd2c4ac45601..0d5ff03cb091 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -130,8 +130,7 @@ static void mdp5_plane_destroy_state(struct drm_plane > *plane, > { > struct mdp5_plane_state *pstate = to_mdp5_plane_state(state); > > - if (state->fb) > - drm_framebuffer_put(state->fb); > + __drm_atomic_helper_plane_destroy_state(state); > > kfree(pstate); > } > -- > 2.40.1 >
