Hi Jingfeng, Am Mittwoch, dem 19.07.2023 um 00:16 +0800 schrieb suijingfeng: > Hi, > > > [...] > > > I don't think you are right here. > > > > > Yes, clearly I was not taking into account the differences between > > drm_gem_private_object_init and drm_gem_object_init properly. Please > > disregard my comment, this patch is good as-is. > > I have study your patch in the past frequently. > > As you could solve very complex(and difficulty) bugs. > > So I still believe that you know everything about etnaviv. > While flattering, even I myself am not thinking I know everything about etnaviv. The different HW generations and the complex subsystem the driver is living in doesn't make it easy for anyone to keep in mind everything.
> I'm just wondering that you are designing the traps. But I'm not sure. > Certainly not. I'm just human and do make mistakes as everyone. During the quick scrolling though the code when reviewing this patch my mind clearly just dropped the _private_ part of one of the function names. I appreciate being told when I am wrong and I do believe that the exchange during the review is helpful for everyone to get on the same page. Regards, Lucas > Okay, still acceptable. > > Because communicate will you is interesting. > > Thank you. > > > Regards, > > Lucas > > > > > > Regards, > > > > Lucas > > > > > > > > > Signed-off-by: Sui Jingfeng <[email protected]> > > > > > --- > > > > > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 +++---- > > > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > > > > b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > > > > index b5f73502e3dd..be2f459c66b5 100644 > > > > > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > > > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > > > > @@ -542,7 +542,7 @@ static const struct drm_gem_object_funcs > > > > > etnaviv_gem_object_funcs = { > > > > > .vm_ops = &vm_ops, > > > > > }; > > > > > > > > > > -static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, > > > > > u32 flags, > > > > > +static int etnaviv_gem_new_impl(struct drm_device *dev, u32 flags, > > > > > const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj) > > > > > { > > > > > struct etnaviv_gem_object *etnaviv_obj; > > > > > @@ -591,8 +591,7 @@ int etnaviv_gem_new_handle(struct drm_device > > > > > *dev, struct drm_file *file, > > > > > > > > > > size = PAGE_ALIGN(size); > > > > > > > > > > - ret = etnaviv_gem_new_impl(dev, size, flags, > > > > > - &etnaviv_gem_shmem_ops, &obj); > > > > > + ret = etnaviv_gem_new_impl(dev, flags, &etnaviv_gem_shmem_ops, > > > > > &obj); > > > > > if (ret) > > > > > goto fail; > > > > > > > > > > @@ -627,7 +626,7 @@ int etnaviv_gem_new_private(struct drm_device > > > > > *dev, size_t size, u32 flags, > > > > > struct drm_gem_object *obj; > > > > > int ret; > > > > > > > > > > - ret = etnaviv_gem_new_impl(dev, size, flags, ops, &obj); > > > > > + ret = etnaviv_gem_new_impl(dev, flags, ops, &obj); > > > > > if (ret) > > > > > return ret; > > > > > >
