On 6/14/2023 10:15 AM, Jeffrey Hugo wrote:
From: Pranjal Ramajor Asha Kanojiya <[email protected]>

smatch warning:
        drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:
                dereferencing freed memory 'obj->import_attach'

obj->import_attach is detached and freed using dma_buf_detach().
But used after free to decrease the dmabuf ref count using
dma_buf_put().

drm_prime_gem_destroy() handles this issue and performs the proper clean
up instead of open coding it in the driver.

Fixes: ff13be830333 ("accel/qaic: Add datapath")
Reported-by: Sukrut Bellary <[email protected]>
Closes: 
https://lore.kernel.org/all/[email protected]/
Suggested-by: Christian König <[email protected]>
Signed-off-by: Pranjal Ramajor Asha Kanojiya <[email protected]>
Reviewed-by: Carl Vanderlip <[email protected]>
Reviewed-by: Jeffrey Hugo <[email protected]>
Signed-off-by: Jeffrey Hugo <[email protected]>

Pushed to drm-misc-fixes

-Jeff

Reply via email to