On Fri, 09 Jun 2023, Matthias Brugger wrote: > > > On 09/06/2023 10:17, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter > > or member 'clk' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter > > or member 'regs' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter > > or member 'cmdq_reg' not described in 'mtk_disp_ccorr' > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter > > or member 'data' not described in 'mtk_disp_ccorr' > > > > Cc: Chun-Kuang Hu <[email protected]> > > Cc: Philipp Zabel <[email protected]> > > Cc: David Airlie <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Matthias Brugger <[email protected]> > > Cc: AngeloGioacchino Del Regno <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Lee Jones <[email protected]> > > --- > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > index 1773379b24398..720f3c7ef7b4f 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > > @@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data { > > u32 matrix_bits; > > }; > > -/** > > - * struct mtk_disp_ccorr - DISP_CCORR driver structure > > - * @ddp_comp - structure containing type enum and hardware resources > > - * @crtc - associated crtc to report irq events to > > - */ > > That surely suppress the warning but I think the correct to do here is to > fix the documentation instead of deleting it.
If someone wants to take responsibility for it and author correct documentation, I'm all for it. That is the perfect resolution. If that's not going to happen immediately, I suggest we remove it in the first instance. -- Lee Jones [李琼斯]
