Hi Andi,

On 4/5/2023 1:53 PM, Andi Shyti wrote:
Hi Nirmoy,

Add a mechanism to keep existing data when creating
a ttm object with I915_BO_ALLOC_USER flag.
why do we need this mechanism? What was the logic behind? These
are all questions people might have when checking this commit.
Please be a bit more explicative.

Agree, the commit message is bit short. I will add more content in next
revision.
you don't need to send a new version just for this commit log.

You could just propose a new commit log in the reply and if it's
OK, add it before pushing it.

Let me know what do you think about:

Add a mechanism to preserve existing data when creating a TTM

object with the I915_BO_ALLOC_USER flag. This will be used in the subsequent

patch where the I915_BO_ALLOC_USER flag will be applied to the framebuffer

object. For a pre-allocated framebuffer without the I915_BO_PREALLOC flag,

TTM would clear the content, which is not desirable.

Thanks,

Nirmoy


As you wish.

Andi

Cc: Matthew Auld<[email protected]>
Cc: Andi Shyti<[email protected]>
Cc: Andrzej Hajda<[email protected]>
Cc: Ville Syrjälä<[email protected]>
Cc: Jani Nikula<[email protected]>
Cc: Imre Deak<[email protected]>
Signed-off-by: Nirmoy Das<[email protected]>
Reviewed-by: Andi Shyti<[email protected]>

Thanks,

Nirmoy

Thanks,
Andi

Reply via email to