Daniel Vetter <[email protected]> writes: > vga_default_device really is supposed to cover all corners, at least > for x86. Additionally checking for rom shadowing should be redundant, > because the bios/fw only does that for the boot vga device. > > If this turns out to be wrong, then most likely that's a special case > which should be added to the vgaarb code, not replicated all over. > > Patch motived by changes to the aperture helpers, which also have this > open code in a bunch of places, and which are all removed in a > clean-up series. This function here is just for selecting the default > fbdev device for fbcon, but I figured for consistency it might be good > to throw this patch in on top. > > Note that the shadow rom check predates vgaarb, which was only wired > up in 88674088d10c ("x86: Use vga_default_device() when determining > whether an fb is primary"). That patch doesn't explain why we still > fall back to the shadow rom check. > > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Helge Deller <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Javier Martinez Canillas <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: [email protected] > Cc: "H. Peter Anvin" <[email protected]> > --- > arch/x86/video/fbdev.c | 13 +------------
[...] > + if (pci_dev == vga_default_device()) > return 1; > return 0; or just return pci_dev == vga_default_device() ; Reviewed-by: Javier Martinez Canillas <[email protected]> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
