On Tue, 7 Mar 2023 10:10:55 -0500 Harry Wentland <[email protected]> wrote:
> We an use bitfields to track the support ones for HDMI > and DP. This allows us to print colorspaces in a consistent > manner without needing to know whether we're dealing with > DP or HDMI. > > Signed-off-by: Harry Wentland <[email protected]> > Cc: Pekka Paalanen <[email protected]> > Cc: Sebastian Wick <[email protected]> > Cc: [email protected] > Cc: Uma Shankar <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Cc: Joshua Ashton <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/gpu/drm/drm_connector.c | 131 +++++++++++++++++++------------- > include/drm/drm_connector.h | 1 + > 2 files changed, 78 insertions(+), 54 deletions(-) > ... > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 3e2e1bc7aa04..46c064d9ffef 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -460,6 +460,7 @@ enum drm_colorspace { > DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13, > DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14, > DRM_MODE_COLORIMETRY_BT601_YCC = 15, > + DRM_MODE_COLORIMETRY_MAX Maybe a comment to say that MAX is not a valid value? Given that things like iccMAX exist (even though it makes no sense as a colorspace), MAX could perhaps be confused with something. Or call it DRM_MODE_COLORIMETRY__COUNT? or __END? Thanks, pq
pgpDg8W8JPP0I.pgp
Description: OpenPGP digital signature
