Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation

[Helge Deller]

Hi Lucy,

On 2/7/23 11:06, Lucy Mielke wrote:

This cleans up the indentation according to the Linux kernel coding
style, and should fix the warning created by the kernel test robot.

Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP
        framebuffer driver")

Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: Lucy Mielke <mielkeste...@icloud.com>
---
  drivers/video/fbdev/omap/omapfb_main.c | 32 +++++++++++++++-----------
  1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/drivers/video/fbdev/omap/omapfb_main.c 
b/drivers/video/fbdev/omap/omapfb_main.c
index 1f3df2055ff0..4b673daa32cb 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -78,7 +78,7 @@ static struct platform_device omapdss_device = {
        .name           = "omapdss_dss",
        .id             = -1,
        .dev            = {
-               .release = omapdss_release,
+       .release        = omapdss_release,>          },

This is wrong. "release" belongs inside the .dev
variable, so the previous indenting is correct.

The changes below seem correct.

Helge

  };

@@ -544,19 +544,25 @@ static int set_fb_var(struct fb_info *fbi,
                var->yoffset = var->yres_virtual - var->yres;

        if (plane->color_mode == OMAPFB_COLOR_RGB444) {
-               var->red.offset        = 8; var->red.length        = 4;
-                                               var->red.msb_right   = 0;
-               var->green.offset = 4; var->green.length = 4;
-                                               var->green.msb_right = 0;
-               var->blue.offset  = 0; var->blue.length  = 4;
-                                               var->blue.msb_right  = 0;
+               var->red.offset              = 8;
+               var->red.length              = 4;
+               var->red.msb_right   = 0;
+               var->green.offset    = 4;
+               var->green.length    = 4;
+               var->green.msb_right = 0;
+               var->blue.offset     = 0;
+               var->blue.length     = 4;
+               var->blue.msb_right  = 0;
        } else {
-               var->red.offset       = 11; var->red.length        = 5;
-                                               var->red.msb_right   = 0;
-               var->green.offset = 5;  var->green.length = 6;
-                                               var->green.msb_right = 0;
-               var->blue.offset = 0;  var->blue.length  = 5;
-                                               var->blue.msb_right  = 0;
+               var->red.offset              = 11;
+               var->red.length              = 5;
+               var->red.msb_right   = 0;
+               var->green.offset    = 5;
+               var->green.length    = 6;
+               var->green.msb_right = 0;
+               var->blue.offset     = 0;
+               var->blue.length     = 5;
+               var->blue.msb_right  = 0;
        }

        var->height          = -1;