On Fri, 10 Feb 2023 12:31:15 +0100, Uwe Kleine-König wrote:
> Modify the existing (fb-like) binding to support the drm-like binding in
> parallel.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> .../bindings/display/imx/fsl,imx-lcdc.yaml | 46 ++++++++++++++++++-
> 1 file changed, 45 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml:
allOf: {'if': {'properties': {'compatible': {'contains': {'enum':
['fsl,imx1-lcdc', 'fsl,imx21-lcdc']}}}}, 'then': {'properties': {'display':
False, 'fsl,dmacr': False, 'fsl,lpccr': False, 'fsl,lscr1': False}, 'required':
['port']}, 'else': {'properties': {'port': False}, 'required': ['display']}} is
not of type 'array'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml:
ignoring, error in schema: allOf
Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb:
/example-0/lcdc@53fbc000: failed to match any schema with compatible:
['fsl,imx25-lcdc', 'fsl,imx21-lcdc']
Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb:
/example-0/lcdc@53fbc000: failed to match any schema with compatible:
['fsl,imx25-lcdc', 'fsl,imx21-lcdc']
Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb:
/example-1/fb@10021000: failed to match any schema with compatible:
['fsl,imx21-fb']
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
