On Tue, Feb 07, 2023 at 02:37:16PM -0600, Rob Herring wrote:
> On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote:
> > Hi Neil.
> >
> >
> > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote:
> > > Add missing reg property and update example to add dsi top node.
> > >
> > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox
> > > VTDR6130 AMOLED DSI Panel")
> > > Signed-off-by: Neil Armstrong <[email protected]>
> > > ---
> > > .../bindings/display/panel/visionox,vtdr6130.yaml | 34
> > > ++++++++++++++--------
> > > 1 file changed, 22 insertions(+), 12 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > index 49e2fd4b4e99..84562a5b710a 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > > @@ -16,6 +16,10 @@ properties:
> > > compatible:
> > > const: visionox,vtdr6130
> > >
> > > + reg:
> > > + maxItems: 1
> > > + description: DSI virtual channel
> > > +
> > Other panels using dsi uses a simple
> > " reg: true"
> >
> > I think that would suffice here too.
>
> Yes, because dsi-controller.yaml restricts it to a single entry.
> However, it's description says there can be more than 1 virtual channel
> for a device. In that case, it shouldn't be restricted in
> dsi-controller.yaml and the above with 'maxItems: 1' would be correct.
> So I'd keep this as-is.
Thanks for the explanation.
>
> Acked-by: Rob Herring <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
