On 06-02-2023 15:21, Tvrtko Ursulin wrote:
>
>
> On 03/02/2023 13:52, Aravind Iddamsetty wrote:
>> Obj flags for shmem objects is not being set correctly. Fixes in setting
>> BO_ALLOC_USER flag which applies to shmem objs as well.
>>
>> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on
>> acquire")
>> Cc: <[email protected]> # v5.15+
>
> These tags should have been grouped with the ones below in one block.
>
> I have tidied this while pushing, thanks for the fix and review!
Thanks Tvrtko.
Regards,
Aravind.
>
> Regards,
>
> Tvrtko
>
>> v2: Add fixes tag (Tvrtko, Matt A)
>>
>> Cc: Matthew Auld <[email protected]>
>> Cc: Tvrtko Ursulin <[email protected]>
>> Reviewed-by: Matthew Auld <[email protected]>
>> Signed-off-by: Aravind Iddamsetty <[email protected]>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> index 114443096841..37d1efcd3ca6 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> @@ -596,7 +596,7 @@ static int shmem_object_init(struct
>> intel_memory_region *mem,
>> mapping_set_gfp_mask(mapping, mask);
>> GEM_BUG_ON(!(mapping_gfp_mask(mapping) & __GFP_RECLAIM));
>> - i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, 0);
>> + i915_gem_object_init(obj, &i915_gem_shmem_ops, &lock_class, flags);
>> obj->mem_flags |= I915_BO_FLAG_STRUCT_PAGE;
>> obj->write_domain = I915_GEM_DOMAIN_CPU;
>> obj->read_domains = I915_GEM_DOMAIN_CPU;
