On Thu, Jan 19, 2023 at 03:59:01PM +0800, [email protected] wrote: > From: ye xingchen <[email protected]> > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: ye xingchen <[email protected]> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index df9370e0ff23..50f092b316d0 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1686,7 +1686,6 @@ analogix_dp_probe(struct device *dev, struct > analogix_dp_plat_data *plat_data) > { > struct platform_device *pdev = to_platform_device(dev); > struct analogix_dp_device *dp; > - struct resource *res; > unsigned int irq_flags; > int ret; > > @@ -1740,9 +1739,7 @@ analogix_dp_probe(struct device *dev, struct > analogix_dp_plat_data *plat_data) > > clk_prepare_enable(dp->clock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - dp->reg_base = devm_ioremap_resource(&pdev->dev, res); > + dp->reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Rather than a NULL 3rd argument, couldn't you just use devm_platform_ioremap_resource()? With that: Reviewed-by: Brian Norris <[email protected]> > if (IS_ERR(dp->reg_base)) { > ret = PTR_ERR(dp->reg_base); > goto err_disable_clk; > -- > 2.25.1
