On 12/13/22 21:12, Thomas Zimmermann wrote:
> Add dedicated helper to convert from XRGB8888 to ARGB2101010. Sets
> all alpha bits to make pixels fully opaque.
>
> Signed-off-by: Thomas Zimmermann <[email protected]>
> ---
[...]
> +static void drm_test_fb_xrgb8888_to_argb2101010(struct kunit *test)
> +{
> + const struct convert_xrgb8888_case *params = test->param_value;
> + const struct convert_to_argb2101010_result *result =
> ¶ms->argb2101010_result;
> + size_t dst_size;
> + __u32 *buf = NULL;
> + __u32 *xrgb8888 = NULL;
> + struct iosys_map dst, src;
> +
> + struct drm_framebuffer fb = {
> + .format = drm_format_info(DRM_FORMAT_ARGB8888),
Shouldn't this be DRM_FORMAT_XRGB8888 instead?
Other than that, the patch looks good to me.
Reviewed-by: Javier Martinez Canillas <[email protected]>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
