Hi Maciej, thanks for your patch!
Overall I really appreciate the attempt to use DRM, this looks so much smoother than the previous iterations. On Thu, Oct 20, 2022 at 7:57 PM Maciej Kwapulinski <[email protected]> wrote: > > From: Tomasz Jankowski <[email protected]> > > Get the hardware information from register MMIO_IBUFFS > > Signed-off-by: Tomasz Jankowski <[email protected]> > Tested-by: Mikolaj Grzybowski <[email protected]> > Co-developed-by: Jianxun Zhang <[email protected]> > Signed-off-by: Jianxun Zhang <[email protected]> > Co-developed-by: Maciej Kwapulinski <[email protected]> > Signed-off-by: Maciej Kwapulinski <[email protected]> > +static inline u32 gna_reg_read(struct gna_device *gna_priv, u32 reg) > +{ > + return readl(gna_priv->iobase + reg); > +} If you are consistently using functions like this to read/write registers, you are just re-implmeneting regmap-mmio, see drivers/base/regmap/regmap-mmio.c or look in drivers selecting REGMAP_MMIO and the neat tricks they do to read/write and update registers with regmap. Yours, Linus Walleij
