[AMD Official Use Only - General] Thanks for the fixes! The series is reviewed-by: Evan Quan <[email protected]>
Evan > -----Original Message----- > From: Zhen Ni <[email protected]> > Sent: Wednesday, August 3, 2022 5:20 PM > To: [email protected]; [email protected]; Quan, Evan <[email protected]>; > Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]>; Pan, Xinhui <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Zhen Ni <[email protected]> > Subject: [PATCH 2/2] drm/amd/pm: Fix a potential gpu_metrics_table > memory leak > > Memory is allocated for gpu_metrics_table in > smu_v13_0_5_init_smc_tables(), but not freed in > smu_v13_0_5_fini_smc_tables(). This may cause memory leaks, fix it. > > Signed-off-by: Zhen Ni <[email protected]> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > index b81711c4ff33..267c9c43a010 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c > @@ -167,6 +167,9 @@ static int smu_v13_0_5_fini_smc_tables(struct > smu_context *smu) > kfree(smu_table->watermarks_table); > smu_table->watermarks_table = NULL; > > + kfree(smu_table->gpu_metrics_table); > + smu_table->gpu_metrics_table = NULL; > + > return 0; > } > > -- > 2.20.1 > >
