Hello Thomas,

On 7/21/22 10:16, Thomas Zimmermann wrote:
> Reverse the order of the final two arguments when calling
> aperture_remove_conflicting_devices(). An error report is available
> at [1].
> 
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers")
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Sudip Mukherjee <[email protected]>
> Cc: Teddy Wang <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: "K. Y. Srinivasan" <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Stephen Hemminger <[email protected]>
> Cc: Wei Liu <[email protected]>
> Cc: Dexuan Cui <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Link: https://lore.kernel.org/lkml/[email protected]/ # 1
> ---
>  drivers/video/fbdev/aty/radeon_base.c | 2 +-
>  drivers/video/fbdev/hyperv_fb.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/aty/radeon_base.c 
> b/drivers/video/fbdev/aty/radeon_base.c
> index e5e362b8c9da..0a8199985d52 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev 
> *pdev)
>       resource_size_t base = pci_resource_start(pdev, 0);
>       resource_size_t size = pci_resource_len(pdev, 0);
>  
> -     return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, 
> false);
> +     return aperture_remove_conflicting_devices(base, size, false, 
> KBUILD_MODNAME);
>  }

I also missed that the order wasn't correct when reviewing.

Reviewed-by: Javier Martinez Canillas <[email protected]> 

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat

Reply via email to