On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote:
> The i.MX8MP contains two syscon registers which are responsible
> for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
> which represents this serializer as a bridge.
> 
> Acked-by: Sam Ravnborg <[email protected]>
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Lucas Stach <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Peng Fan <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Robby Cai <[email protected]>
> Cc: Robert Foss <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: [email protected]
> To: [email protected]
> ---
> V2: - Consistently use fsl,imx8mp-ldb as compatible
>     - Drop items: from compatible:
>     - Replace minItems with maxItems in clocks:
>     - Drop quotes from clock-names const: ldb
>     - Rename syscon to fsl,syscon
>     - Use generic name of ldb-lvds in example
> V3: - Add AB from Sam
>     - Consistently use MX8MP
> V4: - Rename to fsl-ldb all over the place
>     - Put the LDB node under media block controller in the example
> ---
>  .../bindings/display/bridge/fsl,ldb.yaml      | 92 +++++++++++++++++++
>  1 file changed, 92 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml

A little quick on the applying...

> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml 
> b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> new file mode 100644
> index 000000000000..77f174eee424
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8MP DPI to LVDS bridge chip
> +
> +maintainers:
> +  - Marek Vasut <[email protected]>
> +
> +description: |
> +  The i.MX8MP mediamix contains two registers which are responsible
> +  for configuring the on-SoC DPI-to-LVDS serializer. This describes
> +  those registers as bridge within the DT.

This is a subblock of the mediamix? Please add 'reg' for the 2 registers 
even if you use a regmap.

I didn't find a binding for mediamix. You really need the containing 
block binding before a child node.

Rob

Reply via email to