On Fri, 22 Apr 2022 at 06:10, Yang Yingliang <[email protected]> wrote: > > It will cause null-ptr-deref if platform_get_resource_byname() returns NULL, > we need check the return value. > > Fixes: c6a57a50ad56 ("drm/msm/hdmi: add hdmi hdcp support (V3)") > Signed-off-by: Yang Yingliang <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]> > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index ec324352e862..07e2ad527af9 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -142,6 +142,10 @@ static struct hdmi *msm_hdmi_init(struct platform_device > *pdev) > /* HDCP needs physical address of hdmi register */ > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > config->mmio_name); > + if (!res) { > + ret = -EINVAL; > + goto fail; > + } > hdmi->mmio_phy_addr = res->start; > > hdmi->qfprom_mmio = msm_ioremap(pdev, config->qfprom_mmio_name); > -- > 2.25.1 > -- With best wishes Dmitry
