On Tue, 25 Jan 2022, Lucas De Marchi <[email protected]> wrote:
> Only x86 and in some cases PPC have support added in drm_cache.c for the
> clflush class of functions. However warning once is sufficient to taint
> the log instead of spamming it with "Architecture has no drm_cache.c
> support" every few millisecond.
>
> Cc: Maarten Lankhorst <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Signed-off-by: Lucas De Marchi <[email protected]>
> ---
> drivers/gpu/drm/drm_cache.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index f19d9acbe959..2d5a4c463a4f 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -112,7 +112,6 @@ drm_clflush_pages(struct page *pages[], unsigned long
> num_pages)
> kunmap_atomic(page_virtual);
> }
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
An alternative would be to replace the two lines with:
WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
But I'm not insisting.
BR,
Jani.
> #endif
> }
> @@ -143,7 +142,6 @@ drm_clflush_sg(struct sg_table *st)
> if (wbinvd_on_all_cpus())
> pr_err("Timed out waiting for cache flush\n");
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
> #endif
> }
> @@ -177,7 +175,6 @@ drm_clflush_virt_range(void *addr, unsigned long length)
> if (wbinvd_on_all_cpus())
> pr_err("Timed out waiting for cache flush\n");
> #else
> - pr_err("Architecture has no drm_cache.c support\n");
> WARN_ON_ONCE(1);
> #endif
> }
--
Jani Nikula, Intel Open Source Graphics Center
